ConcourseSuite Support

Support
Corporate
PUBLIC PROFILE

Back to topics

Suggestions

Bug in Admin module (Beta 2)

You need to be logged in to post messages

Bug in Admin module (Beta 2)

12/6/2007 11:17 AM EST

Hi guys,

I just discovered that if you disallow all access to "Edit" under "System Configuration" under the "Admin" module for a given role, users with that role can still edit both "business process management" as well as "HTTP-XML API Client Manager" under "Configure System" in the "Admin" module. The other fields seem fine. (The UI even looks funny for that user, as there is an extra column for those two rows where the "Edit" link appears.)

I'm running Beta 2 on Ubuntu 7.10 64-bit with Sun JDK 1.5, Tomcat 5.5, and PostgreSQL 8.2.

~Tom

1. 1/31/2008 3:04 PM EST

Hi everyone,

FYI, I looked into this bug and just added a couple lines to make it work correctly. I've attached a patch which I hope is helpful. (I've never done a patch before, so please forgive me - and teach me - if I did something wrong!)

Thanks!

~Tom

PS: Ummm... it seems the "Attach files" link doesn't work in my browser. I'll paste the patch below:

Index: /home/hallmant/eclipse/dm-concourse/src/web/jsp/admin/admin_global_params.jsp

=================================================================

--- /home/hallmant/eclipse/dm-concourse/src/web/jsp/admin/admin_global_params.jsp (revision 3)
+++ /home/hallmant/eclipse/dm-concourse/src/web/jsp/admin/admin_global_params.jsp (working copy)
@@ -77,11 +77,13 @@
</td>
</tr>
<tr class="row<%= (++count % 2 == 0 ? "1":"2") %>">
- <td align="center">
- <a href="AdminConfig.do?command=Modify&param=WORKFLOW"><dhv:label
- name="accounts.accounts_contacts_oppcomponent_list.Edit">
- Edit</dhv:label></a>
- </td>
+ <dhv:permission name="admin-sysconfig-edit">
+ <td align="center">
+ <a href="AdminConfig.do?command=Modify&param=WORKFLOW"><dhv:label
+ name="accounts.accounts_contacts_oppcomponent_list.Edit">
+ Edit</dhv:label></a>
+ </td>
+ </dhv:permission>
<td>
<dhv:label name="admin.config.businessProcessManagement">Business Process
Management</dhv:label>
@@ -95,11 +97,13 @@
</td>
</tr>
<tr class="row<%= (++count % 2 == 0 ? "1":"2") %>">
- <td align="center">
- <a href="AdminClientManager.do?command=ShowClients"><dhv:label
- name="accounts.accounts_contacts_oppcomponent_list.Edit">
- Edit</dhv:label></a>
- </td>
+ <dhv:permission name="admin-sysconfig-edit">
+ <td align="center">
+ <a href="AdminClientManager.do?command=ShowClients"><dhv:label
+ name="accounts.accounts_contacts_oppcomponent_list.Edit">
+ Edit</dhv:label></a>
+ </td>
+ </dhv:permission>
<td>
<dhv:label name="admin.hTTP-XMLClientManager">HTTP-XML API Client
Manager</dhv:label>

1 result found